Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): more verbosity on importing #2621

Merged
merged 5 commits into from
Jul 11, 2022
Merged

feat(db): more verbosity on importing #2621

merged 5 commits into from
Jul 11, 2022

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Jun 27, 2022

Adds more verbosity during importing, I am not sure if we can add more.

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@Mte90 Mte90 requested a review from tomjn June 27, 2022 13:53
@update-docs
Copy link

update-docs bot commented Jun 27, 2022 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@Mte90
Copy link
Member Author

Mte90 commented Jun 27, 2022

Basically improve the unbound variable and set in case the variable is not set, so during provision is able to add the log like should be.

@Mte90
Copy link
Member Author

Mte90 commented Jun 27, 2022

Tested and work on provision and also if launched manually, covers both the cases of the patch of few days ago.

@Mte90
Copy link
Member Author

Mte90 commented Jul 11, 2022

@tomjn can you approve that one?

tomjn
tomjn previously approved these changes Jul 11, 2022
View reviewed changes
@tomjn
Copy link
Member

tomjn commented Jul 11, 2022

@Mte90 needs changelog update

@Mte90
Copy link
Member Author

Mte90 commented Jul 11, 2022

Changelog updated

tomjn
tomjn reviewed Jul 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tomjn tomjn merged commit 41e7850 into develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjn tomjn tomjn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mte90 @tomjn